fix(pty): kill all PTYs on will-quit to prevent MSVC assertion crash#51
Merged
Merged
Conversation
When wmux closes without explicitly killing PTY processes, node-pty's libuv async handles (batons) are still pending as the process tears down, triggering: Assertion failed! Expression: remove_pty_baton(baton->id) Add ptyManager.killAll() as the first step in the will-quit handler so node-pty can complete its cleanup before any other shutdown runs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Owner
|
Merged and shipped in v0.8.8 🚀 Thanks @schroldgames! One-line, high-value — |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #50.
Problem
The
will-quithandler tears down ancillary services but never callsptyManager.killAll(). When Electron exits with PTY processes still live, node-pty's libuv async handles (batons) are pending as the runtime tears down, triggering:Fix
One line — call
ptyManager.killAll()first inwill-quit:🤖 Generated with Claude Code