This repository was archived by the owner on Sep 10, 2026. It is now read-only.
fix: Add postgres compatibility in HiveTableLastUpdatedExtractor - #1879
Merged
feng-tao merged 2 commits intoAug 2, 2022
Conversation
chonyy
force-pushed
the
postgres-compatibility-in-hive-table-last-updated-extractor
branch
from
May 29, 2022 13:02
ae5d286 to
27454f2
Compare
Contributor
Author
|
Same unit test import problem as mentioned here: #1878 (comment) |
chonyy
force-pushed
the
postgres-compatibility-in-hive-table-last-updated-extractor
branch
from
June 8, 2022 17:34
27454f2 to
bdc06cc
Compare
Member
|
@chonyy could you rebase and fix the CI? will take a look once it is updated. sorry for the late |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
chonyy
force-pushed
the
postgres-compatibility-in-hive-table-last-updated-extractor
branch
from
July 12, 2022 06:05
bdc06cc to
0431f18
Compare
Signed-off-by: Tony Chou <tcheon8788@gmail.com>
chonyy
force-pushed
the
postgres-compatibility-in-hive-table-last-updated-extractor
branch
from
July 12, 2022 06:13
e4a8550 to
b37637d
Compare
…her it's postgres or not Signed-off-by: Tony Chou <tcheon8788@gmail.com>
chonyy
force-pushed
the
postgres-compatibility-in-hive-table-last-updated-extractor
branch
from
July 12, 2022 06:29
b37637d to
d9af982
Compare
Contributor
Author
|
Hi @feng-tao , all ci unit tests are passed. Pls help me take a look at it when you have time, thanks 🙏 |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
feng-tao
approved these changes
Aug 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Tests
This change has been running in our production environment for a couple of months. I believe no additional unit test is needed since it's simply fixing an unexpected behavior.
CheckList
Make sure you have checked all steps below to ensure a timely review.