Skip to content

POC: add unit test for browse - #3

Draft
andlaus wants to merge 1 commit into
browse_DtcDOPfrom
test_browse
Draft

andlaus wants to merge 1 commit into
browse_DtcDOPfrom
test_browse

Conversation

@andlaus

@andlaus andlaus commented Sep 11, 2026

Copy link
Copy Markdown
Owner

this has been completely auto-generated by copilot CLI using the Kimi 2.7 Code model. This PR is not intended to be merged, just to show how such a test could look like. IMO we should not test the tool completely because it significantly hinders people from modifying the interactive aspects of the tool manually, and for people using an AI coding tool, the unit test does not really matter anyway. That said, it might be a good idea to unit test the non-interactive parts of the code...

any opinions, @kayoub5 ?

this has been auto-generated by copilot CLI using Kimi 2.7 Code.

Signed-off-by: Andreas Lauser <andreas.lauser@mercedes-benz.com>
@kayoub5

kayoub5 commented Sep 11, 2026

Copy link
Copy Markdown

The main issue is that most of the test code is creating fake objects instead of re-using the existing models like examples/somersaultecu.py

@andlaus

andlaus commented Sep 12, 2026 •

Copy link
Copy Markdown
Owner Author

AFAICS this is mainly because the somersault ECU currently does not expose all features required to get good code coverage of browse.py. (They could be added to the somersault example, but IMO it already is unwieldy enough.) That said, I don't think that it is a good idea to unit test the interactive aspects of browse anyway...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants