Use pydantic for configuration validation and modelling#8
Open
Use pydantic for configuration validation and modelling#8
Conversation
This comes with some necessary changes to support the change in configuration handling, such as allowing the user to specify which class they are using for the Client property in modules. This means that the Config class can be subclassed to support custom attributes (assuming a subclass of discord.Client or eris.Core is used).
Also, narrow what types are allowed for GenericModuleBase.
Mainly disabling a cyclic import warning since it is handled already (by moving the modulebase import into a function).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.