Skip to content

Make testutils-paging a KMP - #578

Closed
veyndan wants to merge 1 commit into
androidx:androidx-mainfrom
veyndan:270612487/kmp-testutils-paging
Closed

veyndan wants to merge 1 commit into
androidx:androidx-mainfrom
veyndan:270612487/kmp-testutils-paging

Conversation

@veyndan

@veyndan veyndan commented Jun 30, 2023

Copy link
Copy Markdown
Contributor

Test: ./gradlew test connectedCheck
Bug: 270612487

@claraf3

claraf3 commented Jun 30, 2023

Copy link
Copy Markdown
Member

Are we going to move jvm-free files to common later?

@veyndan

veyndan commented Jun 30, 2023

Copy link
Copy Markdown
Contributor Author

That's the plan! We can move them over to commonMain when the dependent classes in paging-common have been moved over to commonMain.

@veyndan
veyndan force-pushed the 270612487/kmp-testutils-paging branch from 7328dab to fc94e33 Compare July 4, 2023 21:06
@veyndan

veyndan commented Jul 4, 2023

Copy link
Copy Markdown
Contributor Author

@claraf3 Moved classes over to commonMain!

@veyndan veyndan changed the title Make testutils-paging a KMP, with only a JVM implementation Make testutils-paging a KMP Jul 4, 2023
@veyndan
veyndan force-pushed the 270612487/kmp-testutils-paging branch from fc94e33 to 0b0b9bf Compare July 4, 2023 21:19
@veyndan
veyndan force-pushed the 270612487/kmp-testutils-paging branch from 0b0b9bf to 0cfc844 Compare July 4, 2023 21:22
@copybara-service copybara-service Bot closed this in 89b052d Jul 5, 2023
@veyndan
veyndan deleted the 270612487/kmp-testutils-paging branch July 5, 2023 21:54
harryzz pushed a commit to harryzz/compose-multiplatform-core that referenced this pull request Jul 28, 2026
Test: ./gradlew test connectedCheck
Bug: 270612487

This is an imported pull request from androidx#578.

Resolves JetBrains#578
Github-Pr-Head-Sha: 0cfc844
GitOrigin-RevId: f080b43
Change-Id: I47c19416f1c031afd60edd1af1119380c7555cf4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants