Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new configuration option,
ANONADDY_PROXY_AUTHENTICATION_SYNC_EMAIL(defaulting totrue), which controls whether a user's default recipient email address in AnonAddy should be automatically synchronized with the email provided by the proxy authentication headers.Motivation / Use Case
Previously, when logging in via proxy authentication, the email address provided by the proxy was always synchronized with the user's default recipient email.
This behavior can be undesirable when users prefer to use a different email address to log into their authentication provider (e.g., Authelia, Authentik, etc.) than the one they want to use as their actual forwarding recipient in AnonAddy. This change allows users and administrators to disable this automatic synchronization to decouple the authentication email from the AnonAddy recipient email.
Changes
•
.env.example&config/anonaddy.php: Added theANONADDY_PROXY_AUTHENTICATION_SYNC_EMAILenvironment variable and config option.•
ProxyAuthentication.php: Updated the proxy authentication middleware to check the new configuration and skip theupdateDefaultRecipientIfNeededlogic whenshouldSyncEmailis set tofalse.