Repository navigation
Conversation
mekya
left a comment
There was a problem hiding this comment.
Hi @jantekb
There are two things.
- Please make the tests pass.
- Make sure it passes the following scenario. I highly encourage you to write integration test code because this simple change may cause too much headache to us if it works for the below scenario.
- Let a user having username/password signup/login to the webpanel
- Upgrade the server with this improvement
- Check that user with same username/password login to the webpanel
PS: There are some version upgrade scenarios are running on enterprise side, so you may write this test code easily.
|
@mekya an integration test for that would run every time in the next many years, making it necessary to install a pre-argon2 version, run the upgrade and then test it. I think it would be more economical to test the |
|
proactively I have covered the upgrade path (positive and negative) in f9a337f |
Hi @jantekb I want you to make sure that you are covering the scenario below. The simple and fast way is preferred.
If you are saying that it already covers, that's ok. |
c8c9af8 to
38f7587
Compare
|
|
#7796