Repository navigation
Conversation
jantekb
marked this pull request as ready for review
July 23, 2026 12:20
jantekb
commented
Jul 23, 2026
| Process process = AppFunctionalV2Test.execute("sudo service antmedia restart"); | ||
| assertEquals(0, process.exitValue()); | ||
| Process process = AppFunctionalV2Test.execute("sudo service antmedia restart"); | ||
| Awaitility.await().atMost(60, TimeUnit.SECONDS).pollInterval(1, TimeUnit.SECONDS) |
Contributor
Author
There was a problem hiding this comment.
Here is the main point of the fix, adding a wait time until the command itself finishes
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#7974
What changed
sudo service antmedia restartto complete before reading the process exit code.finallyblock.Root cause
AppFunctionalV2Test.execute()returns once theProcessobject is created, buttestRestartServerUnderHttpLoad()immediately calledexitValue(). If the restart was still running, Java threwIllegalThreadStateException. The asynchronous restart then continued and caused cascading failures in later tests while AMS was initializing or enforcing its restored IP filter settings.Validation
mvn -DskipTests test-compile -Dgpg.skip=true -Djarsigner.skip=true -Dmaven.javadoc.skip=truegit diff --checkThe full integration method was not run locally because it invokes
sudo service antmedia restartagainst the installed server.Fixes #7974