Repository navigation
Get HLS initialization to its own thread instead of blocking parent thread - #7913
Open
golgetahir wants to merge 11 commits into
Open
golgetahir wants to merge 11 commits into
golgetahir wants to merge 11 commits into
Conversation
|
jantekb
reviewed
Jul 9, 2026
| private final Object ioLock = new Object(); | ||
| private volatile CountDownLatch ioDoneLatch; | ||
| //the Vert.x worker running the async open/write, so teardown called from that same thread doesn't wait on itself | ||
| private volatile Thread ioThread; |
Contributor
There was a problem hiding this comment.
Let's not fall back to low-level handcoded threading. We have plenty of threading options on higher level, vertx, spring @async or even executor services. In this case I suggest using executor service
jantekb
requested changes
Jul 9, 2026
jantekb
reviewed
Jul 9, 2026
jantekb
left a comment
Contributor
There was a problem hiding this comment.
see the comment on threading
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/ant-media/Ant-Media-Server/issues/{__Enter issue number__}