Repository navigation
Conversation
master312
marked this pull request as ready for review
September 3, 2026 16:49
1 of 3 tasks
master312
force-pushed
the
fix/hls-spec-complience
branch
2 times, most recently
from
September 29, 2026 13:38
2e4fe55 to
76493d7
Compare
…number, and don't change during the stream.
master312
force-pushed
the
fix/hls-spec-complience
branch
from
September 30, 2026 08:42
76493d7 to
78d3c75
Compare
|
jantekb
reviewed
Oct 6, 2026
| * Gets stable bandwidth for generation of _adaptive master file, since that's what spec requires. | ||
| * Tries to get it from ABR settings, if ABR is not set then calculates it from the average. | ||
| */ | ||
| public long getStableBandwidth() { |
Contributor
There was a problem hiding this comment.
Missing unit from the method name, making it ambiguous, the best practice is always indicating the unit in the getter or variable method names. Is it bit per sec, byte per sec, etc...?
jantekb
approved these changes
Oct 6, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#8046