Repository navigation
Conversation
notifyEncodedData is called concurrently by the muxer threads of the audio tracks of a WebRTC client. The buffer map was a plain LinkedHashMap and the native side was called concurrently, which contributed to native heap corruption and JVM crashes.
jantekb
force-pushed
the
fix/issue8084-audio-native-crash
branch
from
September 24, 2026 15:18
5c0e649 to
11951c2
Compare
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of the fix for #8084 (JVM crashes with SIGSEGV in WebRTC conferences when participants with audio leave and join).
WebRtcAudioRecord.notifyEncodedDatais called concurrently by theWebRTCMuxerthreads of all audio tracks a WebRTC client plays. The method used an unsynchronizedLinkedHashMapfor the per-track direct buffers and called the nativeEncodedDataIsReadyconcurrently. This PR makes the methodsynchronized.Root cause
The crashes are native heap corruption. The main cause is in the native
libjingle_peerconnection_so:AntMediaAudioEncoderFactorykept raw pointers to audio encoders that WebRTC destroys on reconfiguration or teardown, andEncodedDataIsReadywrote into the freed encoders. That is fixed in the native library (branchfix/issue8084-audio-encoder-uafon the native build server).