Skip to content

[TORCH] Implement avg_pool1d - #7694

Merged
masahi merged 4 commits into
apache:mainfrom
cgerum:f/torch_avgpool1d
Mar 23, 2021
Merged

masahi merged 4 commits into
apache:mainfrom
cgerum:f/torch_avgpool1d

Conversation

@cgerum

@cgerum cgerum commented Mar 18, 2021

Copy link
Copy Markdown
Contributor

This pull request implements avgpool1d support for the relay torch frontend.

@cgerum
cgerum force-pushed the f/torch_avgpool1d branch from 33fe25d to 2a46c15 Compare March 18, 2021 11:21
@masahi

masahi commented Mar 18, 2021

Copy link
Copy Markdown
Member

Thanks, can you unify the avg_pool1d and 2d? They look identical.

@masahi masahi self-assigned this Mar 18, 2021
@cgerum

cgerum commented Mar 18, 2021

Copy link
Copy Markdown
Contributor Author

Thanks for the review, I hope this is what you had in mind.

@masahi

masahi commented Mar 18, 2021

Copy link
Copy Markdown
Member

Yes thanks, please fix the lint error

@cgerum

cgerum commented Mar 18, 2021

Copy link
Copy Markdown
Contributor Author

Lint error should be fixed, should I squash the commits?

@masahi

masahi commented Mar 18, 2021

Copy link
Copy Markdown
Member

No, we do squash merge anyway when the PR is merged.

@masahi

masahi commented Mar 22, 2021

Copy link
Copy Markdown
Member

@cgerum Can you try kick CI again? You can rebase and push.

@cgerum

cgerum commented Mar 22, 2021

Copy link
Copy Markdown
Contributor Author

The builder seems to have timed out. Should I just add a fake commit to retrigger the build?

Ah sorry, missed your last post. The branch has been rebased.

@cgerum
cgerum force-pushed the f/torch_avgpool1d branch from 9e71fbd to 2c2a843 Compare March 22, 2021 15:57
@masahi
masahi merged commit f09f02e into apache:main Mar 23, 2021
@masahi

masahi commented Mar 23, 2021

Copy link
Copy Markdown
Member

Thanks @cgerum

@cgerum
cgerum deleted the f/torch_avgpool1d branch March 23, 2021 09:23
mehrdadh pushed a commit to mehrdadh/tvm that referenced this pull request Mar 23, 2021
* [TORCH] Implement avg_pool1d

* [TORCH] Unify creation of avg_pooling operations

* [TORCH] Add tests for avg pooling with padding

* [TORCH] Make format checks happy with unified avg_pool
mehrdadh added a commit to mehrdadh/tvm that referenced this pull request Mar 23, 2021
mehrdadh added a commit to mehrdadh/tvm that referenced this pull request Mar 23, 2021
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request May 6, 2021
* [TORCH] Implement avg_pool1d

* [TORCH] Unify creation of avg_pooling operations

* [TORCH] Add tests for avg pooling with padding

* [TORCH] Make format checks happy with unified avg_pool
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request May 11, 2021
* [TORCH] Implement avg_pool1d

* [TORCH] Unify creation of avg_pooling operations

* [TORCH] Add tests for avg pooling with padding

* [TORCH] Make format checks happy with unified avg_pool
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants