Skip to content

[Relay][OP] Gather_nd exposed to relay - #2945

Merged
icemelon merged 7 commits into
apache:masterfrom
Laurawly:gather_nd
Apr 2, 2019
Merged

icemelon merged 7 commits into
apache:masterfrom
Laurawly:gather_nd

Conversation

@Laurawly

@Laurawly Laurawly commented Apr 1, 2019

Copy link
Copy Markdown
Contributor

@yzhliu Please review

@Laurawly
Laurawly requested review from icemelon and vinx13 April 1, 2019 23:10
Comment thread python/tvm/relay/frontend/mxnet.py Outdated
"SoftmaxOutput" : _mx_softmax_output,
"SoftmaxActivation" : _mx_softmax_activation,
"smooth_l1" : _mx_smooth_l1,
"gather_nd" : _mx_gather_nd,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can put gather_nd in the _identity_list.

Comment thread python/tvm/relay/frontend/mxnet.py Outdated
@@ -1,4 +1,4 @@
# pylint: disable=invalid-name, import-self, len-as-condition
# pylint: disable=invalid-name, import-self, len-as-condition, unused-argument

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need to disable this pylint if you put gather_nd in the identity_list

@icemelon
icemelon merged commit ae21edd into apache:master Apr 2, 2019
@icemelon

icemelon commented Apr 2, 2019

Copy link
Copy Markdown
Member

Thanks @Laurawly

ajtulloch pushed a commit to ajtulloch/tvm that referenced this pull request Apr 5, 2019
* gather_nd added

* gather_nd test added

* more test added

* fix lint

* fix build error

* fix lint

* comments addressed
wweic pushed a commit to wweic/tvm that referenced this pull request Apr 7, 2019
* gather_nd added

* gather_nd test added

* more test added

* fix lint

* fix build error

* fix lint

* comments addressed
wweic pushed a commit to wweic/tvm that referenced this pull request Apr 7, 2019
* gather_nd added

* gather_nd test added

* more test added

* fix lint

* fix build error

* fix lint

* comments addressed
wweic pushed a commit to wweic/tvm that referenced this pull request Apr 8, 2019
* gather_nd added

* gather_nd test added

* more test added

* fix lint

* fix build error

* fix lint

* comments addressed
wweic pushed a commit to wweic/tvm that referenced this pull request Apr 10, 2019
* gather_nd added

* gather_nd test added

* more test added

* fix lint

* fix build error

* fix lint

* comments addressed
wweic pushed a commit to neo-ai/tvm that referenced this pull request Apr 11, 2019
* gather_nd added

* gather_nd test added

* more test added

* fix lint

* fix build error

* fix lint

* comments addressed
ajtulloch pushed a commit to ajtulloch/tvm that referenced this pull request Apr 25, 2019
* gather_nd added

* gather_nd test added

* more test added

* fix lint

* fix build error

* fix lint

* comments addressed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants