Conversation
HT154
force-pushed
the
vmtype
branch
9 times, most recently
from
September 1, 2026 22:01
86f0ba1 to
e3829a8
Compare
HT154
marked this pull request as ready for review
September 1, 2026 22:01
HT154
force-pushed
the
vmtype
branch
4 times, most recently
from
September 3, 2026 00:21
23fc10d to
768cef6
Compare
bioball
requested changes
Sep 10, 2026
bioball
left a comment
Member
There was a problem hiding this comment.
This mostly looks good! Left some commentts
HT154
force-pushed
the
vmtype
branch
2 times, most recently
from
September 11, 2026 22:55
74501d6 to
c69c62f
Compare
bioball
requested changes
Sep 14, 2026
bioball
approved these changes
Sep 17, 2026
bioball
left a comment
Member
There was a problem hiding this comment.
Just some minor comments, but approving to unblock!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has some downstream impacts:
CommandSpecParsernow deals withVmTypeinstead ofTypeNodeVmReferencenow deals withVmTypeinstead ofPTypeFunctionNtypes are now exported asPType.Functioninstead ofPType.Class, which may affect consumers of module schema information. This changes pkldoc rendering of such types, which we do not consider a breaking change.pkl:reflectbehavior is unchanged.