adds coverage and failunder to pytest command#68
Merged
Conversation
samgdotson
requested changes
Sep 18, 2024
samgdotson
left a comment
Collaborator
There was a problem hiding this comment.
@fredshone thanks for the pull request! Really above and beyond work. Embarrassingly, I forgot to actually add the coverage test in CI, despite my claims in #65. Regardless, your implementation in pyproject.toml is better than my approach, which was just to have it in the CI.yml.
More embarrassingly, despite appearances osier does not have 99% code coverage (one can dream)! The suggestions I made simply adjust the commands to
- check only the
osiersource files - reduce the passing requirement such that this PR will pass the checks.
Once the changes are adopted, I'm happy to merge (I could accept the changes myself but I feel that decorum dictates I let you do that 😄). Let me know either way -- and thanks again for the PR!
samgdotson
approved these changes
Sep 23, 2024
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nice coverage - would be a shame if you ever let it slip...
Adds pytest-cov dependancy to default dependancies and "straps" to pytest command. So that running pytest also checks coverage.
I have added a fail for if coverage dips below 80%. This is easy to change.