Conversation
Collaborator
|
clang-tidy review says "All clean, LGTM! 👍" |
ckaiser
force-pushed
the
fix/destroyer-unlock
branch
from
August 19, 2026 09:45
c6285f7 to
24bfcf2
Compare
Collaborator
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5988 avoiding a crash by just throwing if we can't unlock the document, should also help in other places that use DocDestroyer since some of them are explicitly catching the lock exceptions but these would've never been throw with the current code., which I'm not sure if it's an oversight or maybe something that got refactored away at some point.