[WIP] Save undo history in .aseprite-undo file by dacap · Pull Request #6022 · aseprite/aseprite

dacap · 2026-09-04T22:05:20Z

This is a work-in-progress draft to implement #3718. There is a lot of work to be done yet, a lot of PRINTARGS for debugging purposes, etc.

The idea behind .aseprite-undo files is to create a text format (as it's right now, for debugging purposes), and a binary format (to reduce the size). Then we should be able to embed the binary format in a .aseprite chunk in a future.

Don't expect compatibility/stability with these .aseprite-undo files at the moment (right now there are crashes, a lot).

aseprite-bot

clang-tidy made some suggestions

aseprite-bot · 2026-09-04T22:23:58Z

+    break;
+
+  Cmd* cmd = nullptr;
+  switch (t) {


warning: switching on non-enum value without default case may not cover all cases [bugprone-switch-missing-default-case]

switch (t) { ^

aseprite-bot · 2026-09-04T22:23:58Z

+void TextDecCmdSerial::cmdtype(cmdtype_t& t)
+{
+  auto tok = nextToken();
+  t = make_cmdtype(tok.size() > 0 ? tok[0] : ' ',


warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]

Suggested change

t = make_cmdtype(tok.size() > 0 ? tok[0] : ' ',

t = make_cmdtype(!tok.empty() ? tok[0] : ' ',

Additional context

/usr/include/c++/15/bits/basic_string.h:1330: method 'basic_string'::empty() defined here

empty() const _GLIBCXX_NOEXCEPT ^

aseprite-bot · 2026-09-04T22:23:58Z

+
+class CmdSerial : public doc::SubObjectsIO {
+public:
+  enum Coding { Decoding = 0, Encoding = 1 };


warning: enum 'Coding' uses a larger base type ('unsigned int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size]

enum Coding { Decoding = 0, Encoding = 1 }; ^

aseprite-bot · 2026-09-04T22:23:58Z

+  doc::CelDataRef getCelDataRef(doc::ObjectId celdataId) override;
+
+protected:
+  doc::Sprite* m_sprite = nullptr;


warning: member variable 'm_sprite' has protected visibility [misc-non-private-member-variables-in-classes]

doc::Sprite* m_sprite = nullptr; ^

aseprite-bot · 2026-09-04T22:23:58Z

+
+protected:
+  doc::Sprite* m_sprite = nullptr;
+  dio::FileInterface* m_f = nullptr;


warning: member variable 'm_f' has protected visibility [misc-non-private-member-variables-in-classes]

dio::FileInterface* m_f = nullptr; ^

aseprite-bot · 2026-09-04T22:23:59Z

+}
+
+template<>
+inline void write_object(std::ostream& os, Cel* cel)


warning: function template specialization 'doc::write_object<doc::Cel *>' has a primary template declaration with different parameter names [readability-inconsistent-declaration-parameter-name]

inline void write_object(std::ostream& os, Cel* cel) ^

Additional context

src/doc/object_io.h:18: the primary template declaration seen here

void write_object(std::ostream& os, T obj) ^

src/doc/object_io.h:30: differing parameters are named here: ('cel'), in primary template declaration: ('obj')

inline void write_object(std::ostream& os, Cel* cel) ^

aseprite-bot · 2026-09-04T22:23:59Z

+}
+
+template<>
+inline void write_object(std::ostream& os, Layer* layer)


warning: function template specialization 'doc::write_object<doc::Layer *>' has a primary template declaration with different parameter names [readability-inconsistent-declaration-parameter-name]

inline void write_object(std::ostream& os, Layer* layer) ^

Additional context

src/doc/object_io.h:18: the primary template declaration seen here

void write_object(std::ostream& os, T obj) ^

src/doc/object_io.h:42: differing parameters are named here: ('layer'), in primary template declaration: ('obj')

inline void write_object(std::ostream& os, Layer* layer) ^

aseprite-bot · 2026-09-04T22:23:59Z

+}
+
+template<>
+inline void write_object(std::ostream& os, ImageRef image)


warning: function template specialization 'doc::write_object<std::shared_ptrdoc::Image>' has a primary template declaration with different parameter names [readability-inconsistent-declaration-parameter-name]

inline void write_object(std::ostream& os, ImageRef image) ^

Additional context

src/doc/object_io.h:18: the primary template declaration seen here

void write_object(std::ostream& os, T obj) ^

src/doc/object_io.h:48: differing parameters are named here: ('image'), in primary template declaration: ('obj')

inline void write_object(std::ostream& os, ImageRef image) ^

aseprite-bot · 2026-09-04T22:23:59Z

+}
+
+template<>
+inline void write_object(std::ostream& os, ImageRef image)


warning: the parameter 'image' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]

inline void write_object(std::ostream& os, ImageRef image) ^

aseprite-bot · 2026-09-04T22:23:59Z

+}
+
+template<>
+inline ImageRef read_object(std::istream& is, SubObjectsIO* subObjects)


warning: parameter 'subObjects' is unused [misc-unused-parameters]

Suggested change

inline ImageRef read_object(std::istream& is, SubObjectsIO* subObjects)

inline ImageRef read_object(std::istream& is, SubObjectsIO* /*subObjects*/)

aseprite-bot

clang-tidy made some suggestions

aseprite-bot · 2026-09-07T18:51:27Z

+  doc::Sprite* m_sprite = nullptr;
+  dio::FileInterface* m_f = nullptr;
+  IdsMap m_idsMap;
+  Coding m_coding = Coding::Decoding;


warning: member variable 'm_idsMap' has protected visibility [misc-non-private-member-variables-in-classes]

IdsMap m_idsMap; ^

aseprite-bot

clang-tidy made some suggestions

aseprite-bot · 2026-09-07T18:51:49Z

+  doc::Sprite* m_sprite = nullptr;
+  dio::FileInterface* m_f = nullptr;
+  IdsMap m_idsMap;
+  Coding m_coding = Coding::Decoding;


warning: member variable 'm_coding' has protected visibility [misc-non-private-member-variables-in-classes]

Coding m_coding = Coding::Decoding; ^

aseprite-bot

clang-tidy made some suggestions

aseprite-bot · 2026-09-08T22:20:53Z

+  dio::FileInterface* m_f = nullptr;
+  IdsMap m_idsMap;
+  Coding m_coding = Coding::Decoding;
+  bool m_beforeCurState = true;


warning: member variable 'm_beforeCurState' has protected visibility [misc-non-private-member-variables-in-classes]

bool m_beforeCurState = true; ^

aseprite-bot · 2026-09-08T22:20:53Z

+  void operator()(gfx::Point& pt) override;
+  void operator()(gfx::Rect& rc) override;
+  void operator()(gfx::Region& rg) override;
+  void operator()(serial_span& buf) override;


warning: function 'app::TextDecCmdSerial::operator()' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]

void operator()(serial_span& buf) override; ^

Additional context

src/app/cmd_serial.cpp:352: the definition seen here

void TextDecCmdSerial::operator()(serial_span& span) ^

src/app/cmd_serial.h:126: differing parameters are named here: ('buf'), in definition: ('span')

void operator()(serial_span& buf) override; ^

aseprite-bot

clang-tidy made some suggestions

aseprite-bot · 2026-09-09T17:59:45Z


-  const doc::Image* m_patch;
-  const gfx::Region& m_region;
+  const doc::Image* m_patch = nullptr;


warning: member variable 'm_patch' has protected visibility [misc-non-private-member-variables-in-classes]

const doc::Image* m_patch = nullptr; ^

aseprite-bot · 2026-09-09T17:59:45Z

-  const doc::Image* m_patch;
-  const gfx::Region& m_region;
+  const doc::Image* m_patch = nullptr;
+  const gfx::Region* m_region = nullptr;


warning: member variable 'm_region' has protected visibility [misc-non-private-member-variables-in-classes]

const gfx::Region* m_region = nullptr; ^

aseprite-bot · 2026-09-09T17:59:45Z

+  void operator()(gfx::Point& pt) override;
+  void operator()(gfx::Rect& rc) override;
+  void operator()(gfx::Region& rg) override;
+  void operator()(serial_span& buf) override;


warning: function 'app::TextDecCmdSerial::operator()' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]

void operator()(serial_span& buf) override; ^

Additional context

src/app/cmd_serial.cpp:367: the definition seen here

void TextDecCmdSerial::operator()(serial_span& span) ^

src/app/cmd_serial.h:128: differing parameters are named here: ('buf'), in definition: ('span')

void operator()(serial_span& buf) override; ^

Possible fix for: aseprite/aseprite#3220 Found testing: aseprite/aseprite#6022

dacap self-assigned this Sep 4, 2026

dacap added this to the v1.4-beta1 milestone Sep 4, 2026

dacap linked an issue Sep 4, 2026 that may be closed by this pull request

Saved Undo History #3718

Open

dacap added the record undo label Sep 4, 2026

aseprite-bot reviewed Sep 4, 2026

View reviewed changes

dacap force-pushed the save-undo-history branch 2 times, most recently from 9cf130a to a649d53 Compare September 7, 2026 18:12

Base automatically changed from refactor-cmd-ctx to beta September 7, 2026 18:36

aseprite-bot reviewed Sep 7, 2026

View reviewed changes

dacap force-pushed the save-undo-history branch from a649d53 to 57a330a Compare September 8, 2026 22:02

aseprite-bot reviewed Sep 8, 2026

View reviewed changes

dacap force-pushed the save-undo-history branch from 57a330a to 7e015a4 Compare September 9, 2026 14:05

dacap mentioned this pull request Sep 9, 2026

Internal undo representation improvements #6032

Open

3 tasks

dacap force-pushed the save-undo-history branch from 7e015a4 to 7bbad9e Compare September 9, 2026 17:40

aseprite-bot reviewed Sep 9, 2026

View reviewed changes

[WIP] Save undo history in .aseprite-undo file

cfc890c

dacap force-pushed the save-undo-history branch from 7bbad9e to cfc890c Compare September 14, 2026 19:54

dacap added a commit to dacap/laf that referenced this pull request Sep 14, 2026

Fix encode_base64() w/padding chars when buffer ends with zeros

500768c

Possible fix for: aseprite/aseprite#3220 Found testing: aseprite/aseprite#6022

	t = make_cmdtype(tok.size() > 0 ? tok[0] : ' ',
	t = make_cmdtype(!tok.empty() ? tok[0] : ' ',

	inline ImageRef read_object(std::istream& is, SubObjectsIO* subObjects)
	inline ImageRef read_object(std::istream& is, SubObjectsIO* /subObjects/)

Uh oh!

Conversation

dacap commented Sep 4, 2026

Uh oh!

aseprite-bot left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aseprite-bot left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aseprite-bot left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aseprite-bot left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aseprite-bot left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants