Repository navigation
Add "About this device" panel - #116
Open
iconscious wants to merge 4 commits into
Open
iconscious wants to merge 4 commits into
iconscious wants to merge 4 commits into
Conversation
… track modes Clicking the device name, or the new "About this Walkman" menu item, opens a panel describing the connected recorder: model, manufacturer and USB vendor and product IDs, the disc's size, free space and protection, and how many tracks are recorded in each mode (SP, MONO, LP2, LP4). The device name is a button inside the heading, so it can also be reached and opened from the keyboard. The panel works in the standard look and in Retro Mode. The manufacturer and USB ID rows appear for NetMD devices connected over USB; other services show the model, disc and tracks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Not every MiniDisc recorder is a Walkman: the panel also appears for decks and other brands. The menu item, the tooltip on the device name and the Retro menu item now say "About this device". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…and in the model name Adds the USB vendor IDs netmd-js knows for Panasonic (04DA), Kenwood (0B28) and Buffalo (0411). Some players report another maker's vendor ID (Aiwa's use Sony's), so a brand at the start of the model name now wins over the vendor ID. Every device in netmd-js's list now shows the brand its name starts with. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…n file The mode-name comment now says how it differs from the track list's badge (mono shows as SP there). The Retro dialog imports DeviceInfoRow from device-info-rows.ts, so the two dialog files no longer import each other. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I'm a UX / Product Designer (since the 1990s) and I love Web MiniDisc. While reviving my old Sony MZ-N1 I decided to build a new theme for my own use. I'm not a developer, so the code was written with Claude Code and tested on my player and Mac, so please treat it with the usual care. I'm happy to discuss and make any changes you'd like.
This first PR is a small panel the theme builds on; the theme itself follows as a draft.
Clicking the device name on the main screen, or the new About this device menu item, opens a small panel describing the connected recorder:
It works in the standard look and in Retro Mode (a win95 dialog, from the File menu). The device name is a button inside the heading, so it can be reached with Tab and opened with Enter; it keeps the device name as its accessible name.
To get the USB IDs,
NetMDServicegainsgetDeviceInfo(), which returnsnullby default; onlyNetMDUSBServiceimplements it, fromgetVendor()/getProduct(). Other services (the mocks, remote services, HiMD) show Model, Disc and Tracks.Tested on a Sony MZ-N1 over USB (mouse and keyboard, rename, upload) and on MockMD (standard and Retro looks, Exit and reconnect).
🤖 Generated with Claude Code