refactor(react-ag-ui): share interrupt-response validation between submitInterruptResponses and steerAway#5025
Open
ShobhitPatra wants to merge 1 commit into
Open
Conversation
…bmitInterruptResponses and steerAway
🦋 Changeset detectedLatest commit: edea0fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ShobhitPatra
marked this pull request as ready for review
July 17, 2026 15:33
Contributor
|
Claude finished @ShobhitPatra's task in 1m 40s —— View job Reviewing PR #5025
|
Contributor
|
Reviews (1): Last reviewed commit: "refactor(react-ag-ui): share interrupt-r..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR dedupes the interrupt-response validation in react-ag-ui so both interrupt entry points validate through one shared helper.
What
submitInterruptResponsesandsteerAwayeach carried a near identical per-entry validation loop (interruptId presence, status validity, unknown id, duplicate), differing only in the error prefix. This extracts the loop into one private helper,collectInterruptResponses, onAgUiThreadRuntimeCore.[agui] submitInterruptResponses:vs[agui] steerAway:.cancelled.@assistant-ui/react-ag-ui.Why
The copies had already drifted in wording and check order, and any check added to one method silently misses the other. Sharing the loop keeps the two error surfaces consistent by construction.
Impact
Accept/reject behavior is unchanged; only the error message selected under multiple simultaneous violations moves, plus two wording unifications:
unknown interrupt ids: <ids>unknown interrupt id <id>(matches steerAway)every response must have an interruptIdevery entry must have an interruptIdRationale
The two methods' policies differ by design (submit is strict answer-everything, steerAway is cancel-what-I-skipped), so only the per-entry validation is shared and the policies stay at the call sites.