⚠️ No Changeset found

Latest commit: 51a64b5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Claude finished @ephraimduncan's task in 2m 16s —— View job

Review

Clean, minimal, deletion-only realignment. Both variant files end up byte-identical apart from the flavor-specific dialog import, which matches the parallel radix//base/ convention. No critical issues found.

Verified claims

• No in-repo consumers: grep CommandDialog across the repo returns only the two definitions and their export lists — nothing needed migration. ✓
• No changeset needed: packages/ui has "private": true, so it is exempt per repo policy. The changeset-bot warning can be ignored. ✓
• Registry rationale holds: our registry has no command item of its own — apps/registry/src/registry.ts:581 (model-selector) declares a bare "command" registryDependency, which the shadcn CLI resolves against the official upstream registry. So end users were already receiving upstream's new contract; the vendored copy was the stale one. This PR closes that gap rather than creating one. ✓
• Consistency win: the radix variant previously omitted children from its extra props while the base variant declared it optional; both now carry the same required declaration.
• CI: all checks were still in progress at review time with no failures; the diff is type-safe by inspection (Omit + required children re-add is well-formed against both Dialog flavors).

Notes (non-blocking)

• Upstream contract not independently verified from this sandbox — network fetch of shadcn's command.tsx requires approval I don't have. The claimed upstream shape (showCloseButton = false, direct children in DialogContent, required children via Omit) is consistent with upstream's current composition contract as I know it, but rests on the author's verification.
• The Omit<…, "children"> is technically redundant once the intersection re-adds children as required, but keeping it matches upstream verbatim, which is the point of the PR — no change requested.
• DialogHeader rendered outside DialogContent is a pre-existing upstream quirk, untouched by this diff — correctly left alone.
• The "Deliberately deferred drift" section (skipping InputGroup-based CommandInput because input-group has no Base twin) is a reasonable scoping call and is well documented in the PR body.

Simplify

The simplification pass found no issues — the PR is itself a simplification (it deletes an abstraction layer), introduces no new state, effects, or duplication, and the only candidate nitpick (the redundant Omit) was rejected because removing it would break upstream alignment. Code looks clean.

• Gather context (CI status, previous reviews, diff)
• Review code changes
• Verify claims (no in-repo consumers, registry references, private package)
• Collect simplify agent findings
• Post final review

_{Reviews (1): Last reviewed commit: "refactor(ui): align CommandDialog with u..." | Re-trigger Greptile}