Skip to content

Handle non-file editable URLs in pip list #19867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charliermarsh merged 1 commit into from
Jun 15, 2026
Merged

Handle non-file editable URLs in pip list #19867

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions crates/uv/src/commands/pip/list.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@ use uv_client::{BaseClientBuilder, RegistryClientBuilder};
use uv_configuration::{Concurrency, IndexStrategy, KeyringProviderType};
use uv_distribution_filename::DistFilename;
use uv_distribution_types::{
DependencyMetadata, Diagnostic, IndexCapabilities, IndexLocations, InstalledDist, Name,
RequiresPython,
DependencyMetadata, Diagnostic, IndexCapabilities, IndexLocations, Name, RequiresPython,
};
use uv_fs::Simplified;
use uv_installer::SitePackages;
Expand Down Expand Up @@ -195,7 +194,8 @@ pub(crate) async fn pip_list(
.map(FileType::from),
editable_project_location: dist
.as_editable()
.map(|url| url.to_file_path().unwrap().simplified_display().to_string()),
.and_then(|url| url.to_file_path().ok())
.map(|path| path.simplified_display().to_string()),
})
.collect_vec();
let output = serde_json::to_string(&rows)?;
Expand Down Expand Up @@ -255,18 +255,20 @@ pub(crate) async fn pip_list(
});
}

// Editable column is only displayed if at least one editable package is found.
if results.iter().copied().any(InstalledDist::is_editable) {
// Editable column is only displayed if at least one editable path is found.
if results.iter().any(|dist| {
dist.as_editable()
.is_some_and(|url| url.to_file_path().is_ok())
}) {
columns.push(Column {
header: String::from("Editable project location"),
rows: results
.iter()
.map(|dist| dist.as_editable())
.map(|url| {
url.map(|url| {
url.to_file_path().unwrap().simplified_display().to_string()
})
.unwrap_or_default()
url.and_then(|url| url.to_file_path().ok())
.map(|path| path.simplified_display().to_string())
.unwrap_or_default()
})
.collect_vec(),
});
Expand Down
36 changes: 36 additions & 0 deletions crates/uv/tests/pip/pip_list.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,42 @@ fn list_empty_json() {
);
}

#[test]
fn list_editable_non_file_url() -> Result<()> {
let context = uv_test::test_context!("3.12");

let dist_info = ChildPath::new(context.site_packages()).child("project-1.0.0.dist-info");
dist_info.create_dir_all()?;
dist_info
.child("METADATA")
.write_str("Metadata-Version: 2.1\nName: project\nVersion: 1.0.0\n")?;
dist_info
.child("direct_url.json")
.write_str(r#"{"url":"https://example.com/project","dir_info":{"editable":true}}"#)?;

uv_snapshot!(context.pip_list(), @"
success: true
exit_code: 0
----- stdout -----
Package Version
------- -------
project 1.0.0

----- stderr -----
");

uv_snapshot!(context.pip_list().arg("--format=json"), @r#"
success: true
exit_code: 0
----- stdout -----
[{"name":"project","version":"1.0.0"}]

----- stderr -----
"#);

Ok(())
}

#[test]
#[cfg(feature = "test-pypi")]
fn list_single_no_editable() -> Result<()> {
Expand Down
Loading