Skip to content

Enable PGO for Windows x86-64 uv releases - #21003

Merged
charliermarsh merged 3 commits into
charlie/uv-pgo-macos-arm64from
charlie/uv-pgo-windows-x64
Aug 17, 2026
Merged

charliermarsh merged 3 commits into
charlie/uv-pgo-macos-arm64from
charlie/uv-pgo-windows-x64

Conversation

@charliermarsh

@charliermarsh charliermarsh commented Aug 7, 2026 •

Copy link
Copy Markdown
Member

Summary

This PR enables PGO for uv's Windows x86-64 releases, following the approach outlined in #21001. The existing static-CRT configuration is preserved.

@charliermarsh
charliermarsh force-pushed the charlie/uv-pgo-windows-x64 branch from 9143505 to a4dd368 Compare August 7, 2026 21:06
@charliermarsh
charliermarsh force-pushed the charlie/uv-pgo-windows-x64 branch from 58b79dc to c781274 Compare August 10, 2026 20:23
@charliermarsh
charliermarsh marked this pull request as ready for review August 10, 2026 20:24
@charliermarsh charliermarsh added the internal:releases Related to building and distributing release artifacts of uv label Aug 10, 2026
@charliermarsh
charliermarsh marked this pull request as draft August 10, 2026 20:30
@charliermarsh
charliermarsh force-pushed the charlie/uv-pgo-windows-x64 branch from c781274 to 8204fa6 Compare August 10, 2026 20:46
@charliermarsh
charliermarsh force-pushed the charlie/uv-pgo-windows-x64 branch from 8204fa6 to 0c9fef2 Compare August 10, 2026 20:48
@charliermarsh
charliermarsh force-pushed the charlie/uv-pgo-windows-x64 branch from 0c9fef2 to 47cb3b1 Compare August 10, 2026 20:57
@charliermarsh
charliermarsh force-pushed the charlie/uv-pgo-windows-x64 branch from 47cb3b1 to 03ca556 Compare August 10, 2026 21:13
@charliermarsh
charliermarsh marked this pull request as ready for review August 10, 2026 21:13
@codspeed

codspeed Bot commented Aug 10, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 31 untouched benchmarks
⏩ 6 skipped benchmarks1


Comparing charlie/uv-pgo-windows-x64 (4e6ae4d) with charlie/uv-pgo-macos-arm64 (f81b6ab)

Open in CodSpeed

Footnotes

  1. 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@charliermarsh
charliermarsh marked this pull request as draft August 11, 2026 11:10
Comment on lines +313 to +325
@@ -303,6 +320,32 @@ jobs:
CARGO: ${{ github.workspace }}/scripts/cargo.cmd
# Disable prebuilt NASM objects so we always compile assembly from source.
AWS_LC_SYS_PREBUILT_NASM: "0"
- name: "Build PGO wheels"
if: ${{ matrix.platform.target == 'x86_64-pc-windows-msvc' }}
uses: PyO3/maturin-action@e83996d129638aa358a18fbd1dfb82f0b0fb5d3b # v1.51.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof, I'm sad this has to split. Why?

This branch was previously deployed

1 inactive deployment
automations — 8fc111ca Deployed Aug 17, 2026 by charliermarsh via review / security review #44871
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal:releases Related to building and distributing release artifacts of uv

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants