Repository navigation
Enable PGO for Windows x86-64 uv releases - #21003
Merged
charliermarsh merged 3 commits intoAug 17, 2026
Merged
Conversation
charliermarsh
had a problem deploying
to
automations
August 7, 2026 21:04 — with
GitHub Actions
Error
charliermarsh
force-pushed
the
charlie/uv-pgo-windows-x64
branch
from
August 7, 2026 21:06
9143505 to
a4dd368
Compare
charliermarsh
temporarily deployed
to
automations
August 7, 2026 21:08 — with
GitHub Actions
Inactive
charliermarsh
temporarily deployed
to
automations
August 7, 2026 21:44 — with
GitHub Actions
Inactive
charliermarsh
force-pushed
the
charlie/uv-pgo-windows-x64
branch
from
August 10, 2026 20:23
58b79dc to
c781274
Compare
charliermarsh
marked this pull request as ready for review
August 10, 2026 20:24
charliermarsh
temporarily deployed
to
automations
August 10, 2026 20:25 — with
GitHub Actions
Inactive
charliermarsh
marked this pull request as draft
August 10, 2026 20:30
charliermarsh
force-pushed
the
charlie/uv-pgo-windows-x64
branch
from
August 10, 2026 20:46
c781274 to
8204fa6
Compare
charliermarsh
had a problem deploying
to
automations
August 10, 2026 20:47 — with
GitHub Actions
Error
charliermarsh
force-pushed
the
charlie/uv-pgo-windows-x64
branch
from
August 10, 2026 20:48
8204fa6 to
0c9fef2
Compare
charliermarsh
had a problem deploying
to
automations
August 10, 2026 20:50 — with
GitHub Actions
Error
charliermarsh
force-pushed
the
charlie/uv-pgo-windows-x64
branch
from
August 10, 2026 20:57
0c9fef2 to
47cb3b1
Compare
charliermarsh
temporarily deployed
to
automations
August 10, 2026 20:58 — with
GitHub Actions
Inactive
charliermarsh
force-pushed
the
charlie/uv-pgo-windows-x64
branch
from
August 10, 2026 21:13
47cb3b1 to
03ca556
Compare
charliermarsh
marked this pull request as ready for review
August 10, 2026 21:13
charliermarsh
temporarily deployed
to
automations
August 10, 2026 21:15 — with
GitHub Actions
Inactive
Merging this PR will not alter performance
Comparing Footnotes
|
charliermarsh
marked this pull request as draft
August 11, 2026 11:10
charliermarsh
temporarily deployed
to
automations
August 12, 2026 15:54 — with
GitHub Actions
Inactive
charliermarsh
force-pushed
the
charlie/uv-pgo-windows-x64
branch
from
August 12, 2026 16:17
61e8fc2 to
4eecf86
Compare
charliermarsh
had a problem deploying
to
automations
August 12, 2026 16:19 — with
GitHub Actions
Error
charliermarsh
force-pushed
the
charlie/uv-pgo-windows-x64
branch
from
August 12, 2026 16:24
4eecf86 to
4e6ae4d
Compare
charliermarsh
temporarily deployed
to
automations
August 12, 2026 16:26 — with
GitHub Actions
Inactive
charliermarsh
marked this pull request as ready for review
August 12, 2026 16:28
zanie-oai
reviewed
Aug 13, 2026
Comment on lines
+313
to
+325
| @@ -303,6 +320,32 @@ jobs: | |||
| CARGO: ${{ github.workspace }}/scripts/cargo.cmd | |||
| # Disable prebuilt NASM objects so we always compile assembly from source. | |||
| AWS_LC_SYS_PREBUILT_NASM: "0" | |||
| - name: "Build PGO wheels" | |||
| if: ${{ matrix.platform.target == 'x86_64-pc-windows-msvc' }} | |||
| uses: PyO3/maturin-action@e83996d129638aa358a18fbd1dfb82f0b0fb5d3b # v1.51.0 | |||
Contributor
There was a problem hiding this comment.
Oof, I'm sad this has to split. Why?
charliermarsh
had a problem deploying
to
automations
August 16, 2026 21:15 — with
GitHub Actions
Error
charliermarsh
force-pushed
the
charlie/uv-pgo-windows-x64
branch
from
August 16, 2026 21:19
fd6ed82 to
037c388
Compare
charliermarsh
temporarily deployed
to
automations
August 16, 2026 21:21 — with
GitHub Actions
Inactive
konstin
approved these changes
Aug 17, 2026
zanieb
approved these changes
Aug 17, 2026
charliermarsh
force-pushed
the
charlie/uv-pgo-windows-x64
branch
from
August 17, 2026 19:26
037c388 to
5801509
Compare
charliermarsh
had a problem deploying
to
automations
August 17, 2026 19:27 — with
GitHub Actions
Error
1 task
This was referenced Aug 31, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables PGO for uv's Windows x86-64 releases, following the approach outlined in #21001. The existing static-CRT configuration is preserved.