Repository navigation
Ignore tags in universal resolution - #4174
Merged
Merged
Conversation
charliermarsh
force-pushed
the
charlie/tags
branch
from
June 9, 2024 23:28
5baed1f to
a5283d1
Compare
konstin
approved these changes
Jun 10, 2024
BurntSushi
reviewed
Jun 10, 2024
| } | ||
| TagCompatibility::Compatible(priority) => priority, | ||
| let priority = match tags { | ||
| Some(tags) => match filename.compatibility(tags) { |
Member
There was a problem hiding this comment.
Nit: I think this could be tags.map(|tags| match filename.compatibility(tags) { ... }).
The tip-off was the None => None branch below.
Member
Author
There was a problem hiding this comment.
I thought so too initially but we have an early return on line 174... Doesn't that cause problems?
Member
There was a problem hiding this comment.
Oh derp, I missed the return. Sorry!
| return WheelCompatibility::Incompatible(IncompatibleWheel::Tag(tag)) | ||
| } | ||
| TagCompatibility::Compatible(priority) => priority, | ||
| let priority = match &self.tags { |
Member
There was a problem hiding this comment.
Nit: same as above, although I think this needs self.tags.as_ref().map(...).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If a package lacks a source distribution, and we can't find a compatible wheel for the current platform, we need to just assume that the package will have a valid wheel on all platforms on which it's requested; if not, we raise an error at install time.
It's possible that we can be smarter about this over time. For example, if the package was requested only for macOS, we could verify that there's at least one macOS-compatible wheel. See the linked issue for more details.
Closes #4139.