Repository navigation
Use sitecustomize.py to implement environment layering - #5462
Merged
Merged
Conversation
charliermarsh
force-pushed
the
charlie/rev
branch
from
July 25, 2024 23:20
4bb10fb to
ce513e1
Compare
charliermarsh
commented
Jul 25, 2024
| Resolved 1 package in [TIME] | ||
| Prepared 1 package in [TIME] | ||
| Installed 1 package in [TIME] | ||
| + foo==1.0.0 (from file://[TEMP_DIR]/) |
Member
Author
There was a problem hiding this comment.
Amazingly, this test fails on main. Can't believe we hadn't tried this yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After consultation with @carljm, we learned that modifying
PYTHONPATHis insufficient, because Python won't resolve.pthfiles (editables) in the base environment. We also saw in #5459 that continuously appending toPYTHONPATHcan have some unintended effects.This PR instead uses a
sitecustomize.pyin the ephemeral environment to add the base environment'ssite-packages.Closes #5459.