Repository navigation
Filter mixed sources from --find-links entries in lockfile - #6025
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Our current handling of
--find-linksmerges the entries in each index. As a result, we can end up withAnnotatedDistentries that reference distributions across indexes.I'd like to change
--find-linkssuch that each--find-linksentry is just treated as its own index (so, e.g., ifrequestsexists in the first--find-linksentry, we don't even check the registry by default), which would also fix this problem automatically. But that's a behavior change... So for now, in the lockfile, we filter distributions that don't match the source index URL.There are two cases to consider:
--find-linksregistry, the source distribution must have come from the--find-linksentry, so it's fine to discard any wheels from the "wrong" registry without breaking any compatibility guarantees.--find-linksregistry. We might lose some platform coverage by discarding the other wheels, but it shouldn't break any of the "guarantees", since we have at least one wheel that fits in the version range.Closes #6015.