Repository navigation
Add RUFF_OUTPUT_FILE environment variable support - #10992
Merged
Merged
Conversation
Contributor
|
charliermarsh
approved these changes
Apr 17, 2024
charliermarsh
left a comment
Member
There was a problem hiding this comment.
This seems reasonable to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I've added support for configuring the
ruff checkoutput file via the environment variableRUFF_OUTPUT_FILEakin to #1731.This is super useful when, e.g., generating a GitLab code quality report while running Ruff as a pre-commit hook. Usually,
ruff checkshould print its human-readable output tostdout, but when run throughpre-commitin a GitLab CI job it should write its output ingitlabformat to a file. So, to override these two settings only during CI, environment variables come handy, andRUFF_OUTPUT_FORMATalready exists butRUFF_OUTPUT_FILEhas been missing.A (simplified) GitLab CI job config for this scenario might look like this:
Test Plan
I tested it manually.