Skip to content

Clearly indicate what is counted as a branch - #11423

Merged
charliermarsh merged 4 commits into
astral-sh:mainfrom
jaap3:patch-1
May 16, 2024
Merged

charliermarsh merged 4 commits into
astral-sh:mainfrom
jaap3:patch-1

Conversation

@jaap3

@jaap3 jaap3 commented May 14, 2024 •

Copy link
Copy Markdown
Contributor

Summary

As discussed in issue #11408, PLR0912 has a broader definition of "branches" than I expected. This updates the documentation to include this definition.

I also updated the example to include several different types of branches, while still maintaining dictionary lookup as an alternative solution. (Crafting a realistic example was quite a challenge 😅).

Closes #11408.

@github-actions

github-actions Bot commented May 14, 2024 •

Copy link
Copy Markdown
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Comment thread crates/ruff_linter/src/rules/pylint/rules/too_many_branches.rs
Jaap Roes and others added 2 commits May 14, 2024 14:39
@charliermarsh charliermarsh added the documentation Improvements or additions to public-facing documentation label May 16, 2024
@charliermarsh
charliermarsh enabled auto-merge (squash) May 16, 2024 02:05
@charliermarsh
charliermarsh merged commit b3e4d39 into astral-sh:main May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to public-facing documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PLR0912 seems to overcount branches

3 participants