Repository navigation
Consider soft keywords for E27 rules - #11446
Merged
Merged
Conversation
dhruvmanila
force-pushed
the
dhruv/token-kind-keywords
branch
from
May 16, 2024 11:40
bb02694 to
72e190a
Compare
dhruvmanila
force-pushed
the
dhruv/e27-soft-keyword
branch
from
May 16, 2024 11:40
23a938e to
afe44c6
Compare
dhruvmanila
added a commit
that referenced
this pull request
May 17, 2024
## Summary This PR updates the `TokenKind::is_keyword` check to include soft keywords. To account for this change, it adds a new `is_non_soft_keyword` method. The usage in logical line rules were updated to use the `is_non_soft_keyword` method but it'll be updated to use `is_keyword` in a follow-up PR (#11446). While, the parser usages were kept as is. And because of that, the snapshots for two test cases were updated in a better direction. ## Test Plan `cargo insta test`
AlexWaygood
approved these changes
May 17, 2024
dhruvmanila
force-pushed
the
dhruv/e27-soft-keyword
branch
from
May 17, 2024 12:13
afe44c6 to
8455701
Compare
Contributor
|
dhruvmanila
force-pushed
the
dhruv/e27-soft-keyword
branch
from
May 20, 2024 05:34
8455701 to
ccd8538
Compare
dhruvmanila
enabled auto-merge (squash)
May 20, 2024 05:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a follow-up PR to #11445 update the
E27rules to consider soft keywords as well.Test Plan
Add test cases consisting of soft keywords and update the snapshot.