Skip to content

Treat escaped newline as valid sequence - #11465

Merged
charliermarsh merged 1 commit into
mainfrom
charlie/w
May 19, 2024
Merged

charliermarsh merged 1 commit into
mainfrom
charlie/w

Conversation

@charliermarsh

Copy link
Copy Markdown
Member

Summary

We weren't treating the escaped newline as a valid condition to trigger the safer fix (add an extra backslash before each invalid escape sequence).

Closes #11461.

@charliermarsh charliermarsh added the bug An issue describing something that isn't working, or a PR that fixes a bug label May 19, 2024
@charliermarsh
charliermarsh enabled auto-merge (squash) May 19, 2024 03:28
@charliermarsh
charliermarsh merged commit cfceb43 into main May 19, 2024
@charliermarsh
charliermarsh deleted the charlie/w branch May 19, 2024 03:32
@zanieb

zanieb commented May 19, 2024

Copy link
Copy Markdown
Member

Nice!

@github-actions

Copy link
Copy Markdown
Contributor

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check encountered linter errors. (no lint changes; 1 project error)

commaai/openpilot (error)

Failed to clone commaai/openpilot: fatal: active `post-checkout` hook found during `git clone`:
	/home/runner/work/ruff/ruff/checkouts/commaai:openpilot/.git/hooks/post-checkout
For security reasons, this is disallowed by default.
If this is intentional and the hook should actually be run, please
run the command again with `GIT_CLONE_PROTECTION_ACTIVE=false`
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'

Linter (preview)

✅ ecosystem check detected no linter changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug An issue describing something that isn't working, or a PR that fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

W605 fix is unsafe

2 participants