Skip to content

ruff server: Add tracing setup guide to Neovim documentation - #11884

Merged
snowsignal merged 3 commits into
mainfrom
jane/server/docs/nvim/tracing
Jun 18, 2024
Merged

snowsignal merged 3 commits into
mainfrom
jane/server/docs/nvim/tracing

Conversation

@snowsignal

@snowsignal snowsignal commented Jun 14, 2024 •

Copy link
Copy Markdown
Contributor

A follow-up to this suggestion on the tracing PR.

@snowsignal snowsignal added documentation Improvements or additions to public-facing documentation server Related to the Ruff or ty LSP server labels Jun 14, 2024
@MichaReiser
MichaReiser requested a review from dhruvmanila June 15, 2024 08:11

@dhruvmanila dhruvmanila left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up with the documentation!

I don't think we can directly provide the settings key, it should be under the init_options field. This makes me wonder if there are any other suggestions in the Neovim documentation which uses the settings field directly instead of init_options.

Comment thread crates/ruff_server/docs/setup/NEOVIM.md Outdated
Comment thread crates/ruff_server/docs/setup/NEOVIM.md Outdated
@snowsignal

Copy link
Copy Markdown
Contributor Author

@dhruvmanila Thank you for opening an issue for workspace/didChangeConfiguration! I wasn't aware how this intersected with Neovim configuration.

Co-authored-by: Dhruv Manilawala <dhruvmanila@gmail.com>
@snowsignal
snowsignal requested a review from dhruvmanila June 18, 2024 03:45
@snowsignal
snowsignal merged commit ff3bf58 into main Jun 18, 2024
@snowsignal
snowsignal deleted the jane/server/docs/nvim/tracing branch June 18, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to public-facing documentation server Related to the Ruff or ty LSP server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants