Skip to content

Consider binary expr for parenthesized with items parsing - #11012

Merged
dhruvmanila merged 1 commit into
mainfrom
dhruv/with-items-binary-expr
Apr 18, 2024
Merged

dhruvmanila merged 1 commit into
mainfrom
dhruv/with-items-binary-expr

Conversation

@dhruvmanila

Copy link
Copy Markdown
Member

Summary

This PR fixes the bug in with items parsing where it would fail to recognize that the parenthesized expression is part of a large binary expression.

Test Plan

Add test cases and verified the snapshots.

@dhruvmanila dhruvmanila added bug An issue describing something that isn't working, or a PR that fixes a bug parser Related to the parser labels Apr 18, 2024
@github-actions

Copy link
Copy Markdown
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@dhruvmanila
dhruvmanila merged commit b7066e6 into main Apr 18, 2024
@dhruvmanila
dhruvmanila deleted the dhruv/with-items-binary-expr branch April 18, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug An issue describing something that isn't working, or a PR that fixes a bug parser Related to the parser

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants