Skip to content

Expand tildes when resolving Ruff server configuration file - #11283

Merged
charliermarsh merged 1 commit into
mainfrom
charlie/expand
May 4, 2024
Merged

charliermarsh merged 1 commit into
mainfrom
charlie/expand

Conversation

@charliermarsh

@charliermarsh charliermarsh commented May 4, 2024 •

Copy link
Copy Markdown
Member

Summary

Users can now include tildes and environment variables in the provided path, just like with --config.

Closes #11277.

Test Plan

Set the configuration path to "ruff.configuration": "~/x.toml"; verified that the server attempted to read from /Users/crmarsh/x.toml.

Screenshot 2024-05-04 at 1 31 43 PM

@charliermarsh charliermarsh added bug An issue describing something that isn't working, or a PR that fixes a bug server Related to the Ruff or ty LSP server labels May 4, 2024
@charliermarsh
charliermarsh requested a review from snowsignal May 4, 2024 17:32
Comment thread crates/ruff_server/src/session/settings.rs
@github-actions

github-actions Bot commented May 4, 2024

Copy link
Copy Markdown
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@charliermarsh
charliermarsh merged commit 9d45987 into main May 4, 2024
@charliermarsh
charliermarsh deleted the charlie/expand branch May 4, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug An issue describing something that isn't working, or a PR that fixes a bug server Related to the Ruff or ty LSP server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ruff server still doesn't check E30* errors

2 participants