Skip to content

Treat type(Protocol) et al as metaclass base - #12770

Merged
charliermarsh merged 5 commits into
mainfrom
charlie/meta
Aug 9, 2024
Merged

Treat type(Protocol) et al as metaclass base#12770
charliermarsh merged 5 commits into
mainfrom
charlie/meta

Conversation

@charliermarsh

@charliermarsh charliermarsh commented Aug 9, 2024

Copy link
Copy Markdown
Member

Summary

Closes #12736.

charliermarsh
charliermarsh commented Aug 9, 2024
View reviewed changes
Comment thread crates/ruff_python_semantic/src/analyze/class.rs
charliermarsh
charliermarsh commented Aug 9, 2024
View reviewed changes
Comment thread crates/ruff_python_semantic/src/analyze/class.rs
| ["abc", "ABCMeta"]
| ["enum", "EnumMeta" | "EnumType"]
)
}),

@charliermarsh charliermarsh Aug 9, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only logic change.

charliermarsh
charliermarsh commented Aug 9, 2024
View reviewed changes
Comment thread crates/ruff_python_semantic/src/analyze/class.rs Outdated
charliermarsh
charliermarsh commented Aug 9, 2024
View reviewed changes
Comment thread crates/ruff_python_semantic/src/analyze/class.rs
@charliermarsh charliermarsh added the bug An issue describing something that isn't working, or a PR that fixes a bug label Aug 9, 2024
AlexWaygood
AlexWaygood requested changes Aug 9, 2024
View reviewed changes
Comment thread crates/ruff_python_semantic/src/analyze/class.rs Outdated
Comment thread crates/ruff_python_semantic/src/analyze/class.rs
Comment thread crates/ruff_python_semantic/src/analyze/class.rs
@codspeed

codspeed Bot commented Aug 9, 2024 •
edited
Loading

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #12770 will not alter performance

Comparing charlie/meta (f98f274) with main (37b9bac)

Summary

✅ 32 untouched benchmarks

@github-actions

github-actions Bot commented Aug 9, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

AlexWaygood
AlexWaygood approved these changes Aug 9, 2024
View reviewed changes
Comment thread crates/ruff_python_semantic/src/analyze/class.rs Outdated
Comment thread crates/ruff_python_semantic/src/analyze/class.rs Outdated
charliermarsh and others added 3 commits August 9, 2024 16:04
@charliermarsh @AlexWaygood
Update crates/ruff_python_semantic/src/analyze/class.rs
9796d57 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@charliermarsh @AlexWaygood
Update crates/ruff_python_semantic/src/analyze/class.rs
14035eb 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@charliermarsh
Fix syntax error
f98f274
@charliermarsh

charliermarsh commented Aug 9, 2024

Copy link
Copy Markdown
Member Author

Thanks Alex!

@charliermarsh
charliermarsh enabled auto-merge (squash) August 9, 2024 20:05
@charliermarsh
charliermarsh merged commit 69e1c56 into main Aug 9, 2024
@charliermarsh
charliermarsh deleted the charlie/meta branch August 9, 2024 20:10
@BrewTestBot BrewTestBot mentioned this pull request Aug 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaReiser MichaReiser MichaReiser left review comments
@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees

No one assigned

Labels

bug An issue describing something that isn't working, or a PR that fixes a bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

N805 False positive for class Meta(type(base))

3 participants

@charliermarsh @MichaReiser @AlexWaygood