Repository navigation
[FastAPI] Avoid introducing invalid syntax in fix for fast-api-non-annotated-dependency (FAST002) - #13133
Merged
Conversation
- Context: this rule swaps out default function argument values
for type annotations
- Problem: When this swap occurs after a default argument value is
already present, the function signature is no longer valid python
code (astral-sh#12982)
- Fix: Track default arguments and bail if we hit this condition,
making this fix only sometimes possible.
arkuhn
force-pushed
the
akuhn/FAST002_autofix
branch
from
August 28, 2024 05:10
eff5e04 to
dc94dd4
Compare
Contributor
|
AlexWaygood
approved these changes
Aug 28, 2024
AlexWaygood
left a comment
Member
There was a problem hiding this comment.
Thanks! This seems like a reasonable fix to me
FastAPI] Avoid introducing invalid syntax in fix for fast-api-non-annotated-dependency (FAST002)
AlexWaygood
enabled auto-merge (squash)
August 28, 2024 15:26
CodSpeed Performance ReportMerging #13133 will improve performances by 7.61%Comparing Summary
Benchmarks breakdown
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12982
Addtl:
Test Plan