Repository navigation
[ruff] Implicit class variable in dataclass (RUF045) - #14349
Merged
Merged
Conversation
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| RUF045 | 8 | 8 | 0 | 0 | 0 |
Contributor
Author
|
False positives found by ecosystem checks:
@dataclass
class FontFace:
family: str | None
emphasis: TextEmphasis | None
size_pt: int | None
color: DeviceGray | DeviceRGB | None
fill_color: DeviceGray | DeviceRGB | None
...
replace = dataclasses.replace
@dataclasses.dataclass(frozen=True)
class FuncFixtureInfo:
...
__slots__ = ("argnames", "initialnames", "names_closure", "name2fixturedefs")Special names can be exempted, but I'm not sure what to do about the first. |
Member
|
I'm not saying we shouldn't do it, but requiring type annotations has been controversial in other instances; for example, there's a long thread for RUF012 that does something similar. @AlexWaygood I'd be interested on your take on this before I start reviewing the rule itself. |
InSyncWithFoo
force-pushed
the
RUF045
branch
from
February 14, 2025 04:44
641759f to
404fa94
Compare
dylwil3
approved these changes
Feb 15, 2025
dylwil3
left a comment
Collaborator
There was a problem hiding this comment.
Thank you!
Looking at the ecosystem results, it seems fairly common for users to define a private class variable in their dataclasses. So I've restricted the scope of the rule a little to exempt that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #12877.
Test Plan
cargo nextest runandcargo insta test.