Repository navigation
[flake8-pytest-style] Test function parameters with default arguments (PT028) - #15449
Merged
Merged
Conversation
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| PT028 | 95 | 95 | 0 | 0 | 0 |
Contributor
Author
|
Aside from that change, I think |
MichaReiser
requested changes
Jan 13, 2025
MichaReiser
left a comment
Member
There was a problem hiding this comment.
Thank you. I've a few comments regarding the implementation and I think we should remove the fix.
Member
|
Did you review the ecosystem changes? |
Contributor
Author
|
@MichaReiser Yes. There are a couple of false positives. For example: def test_parallel(num_threads=2, kwargs_list=None):
"""
Decorator to run the same function multiple times in parallel.
...
"""
...def test_server_running(
skip_provision_check: bool = False,
external_host: str = "testserver",
log_file: str | None = None,
dots: bool = False,
) -> Iterator[None]:
...These kinds of false positives can be reduced (the former would no longer be reported) by making |
MichaReiser
approved these changes
Jan 13, 2025
MichaReiser
left a comment
Member
There was a problem hiding this comment.
Thanks for addressing the feedback.
I'm leaning towards not adding the is this a pytest file just yet because it would introduce the need for a new option for those not using the default file name patterns. We can decide to restrict the rule in the future if this comes up often. The other reason why I'm for deferring is that there are still some false negatives because many of the non-test test functions are defined in files prefixed with test_
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #15412.
Test Plan
cargo nextest runandcargo insta test.