[`flake8-bandit`] Move `unsafe-markup-use` from `RUF035` to `S704` by Daverball · Pull Request #15957 · astral-sh/ruff

Daverball · 2025-02-05T08:15:50Z

Summary

RUF035 has been backported into bandit as S704 in this PR

This moves the rule and its corresponding setting to the flake8-bandit category

Test Plan

cargo nextest run

MichaReiser · 2025-02-05T08:17:42Z

Thanks, this has to wait for the next minor release because it's breaking (selecting RUF will no longer select RUF035 and selecting S now selects S704)

github-actions · 2025-02-05T08:28:43Z

`ruff-ecosystem` results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+30 -9 violations, +0 -0 fixes in 4 projects; 51 projects unchanged)

apache/airflow (+1 -1 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview --select ALL

- providers/fab/src/airflow/providers/fab/auth_manager/security_manager/override.py:2307:19: RUF035 Unsafe use of `markupsafe.Markup` detected
+ providers/fab/src/airflow/providers/fab/auth_manager/security_manager/override.py:2307:19: S704 Unsafe use of `markupsafe.Markup` detected

apache/superset (+7 -7 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview --select ALL

- superset/connectors/sqla/models.py:1308:16: RUF035 Unsafe use of `markupsafe.Markup` detected
+ superset/connectors/sqla/models.py:1308:16: S704 Unsafe use of `markupsafe.Markup` detected
- superset/models/dashboard.py:225:16: RUF035 Unsafe use of `markupsafe.Markup` detected
+ superset/models/dashboard.py:225:16: S704 Unsafe use of `markupsafe.Markup` detected
- superset/models/helpers.py:538:16: RUF035 Unsafe use of `markupsafe.Markup` detected
+ superset/models/helpers.py:538:16: S704 Unsafe use of `markupsafe.Markup` detected
- superset/models/helpers.py:567:16: RUF035 Unsafe use of `markupsafe.Markup` detected
+ superset/models/helpers.py:567:16: S704 Unsafe use of `markupsafe.Markup` detected
- superset/models/slice.py:338:16: RUF035 Unsafe use of `markupsafe.Markup` detected
+ superset/models/slice.py:338:16: S704 Unsafe use of `markupsafe.Markup` detected
- superset/models/sql_lab.py:445:16: RUF035 Unsafe use of `markupsafe.Markup` detected
+ superset/models/sql_lab.py:445:16: S704 Unsafe use of `markupsafe.Markup` detected
- superset/utils/core.py:485:16: RUF035 Unsafe use of `markupsafe.Markup` detected
+ superset/utils/core.py:485:16: S704 Unsafe use of `markupsafe.Markup` detected

freedomofpress/securedrop (+21 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview

+ securedrop/journalist_app/account.py:100:20: S704 Unsafe use of `markupsafe.Markup` detected
+ securedrop/journalist_app/account.py:87:20: S704 Unsafe use of `markupsafe.Markup` detected
+ securedrop/journalist_app/admin.py:224:32: S704 Unsafe use of `markupsafe.Markup` detected
+ securedrop/journalist_app/admin.py:279:20: S704 Unsafe use of `markupsafe.Markup` detected
+ securedrop/journalist_app/admin.py:295:20: S704 Unsafe use of `markupsafe.Markup` detected
+ securedrop/journalist_app/col.py:103:17: S704 Unsafe use of `markupsafe.Markup` detected
+ securedrop/journalist_app/col.py:75:13: S704 Unsafe use of `markupsafe.Markup` detected
+ securedrop/journalist_app/main.py:169:17: S704 Unsafe use of `markupsafe.Markup` detected
+ securedrop/journalist_app/main.py:192:21: S704 Unsafe use of `markupsafe.Markup` detected
+ securedrop/journalist_app/main.py:203:21: S704 Unsafe use of `markupsafe.Markup` detected
+ securedrop/journalist_app/utils.py:267:9: S704 Unsafe use of `markupsafe.Markup` detected
+ securedrop/journalist_app/utils.py:337:13: S704 Unsafe use of `markupsafe.Markup` detected
+ securedrop/journalist_app/utils.py:366:13: S704 Unsafe use of `markupsafe.Markup` detected
+ securedrop/journalist_app/utils.py:380:13: S704 Unsafe use of `markupsafe.Markup` detected
+ securedrop/journalist_app/utils.py:503:17: S704 Unsafe use of `markupsafe.Markup` detected
+ securedrop/journalist_app/utils.py:519:13: S704 Unsafe use of `markupsafe.Markup` detected
+ securedrop/source_app/utils.py:37:16: S704 Unsafe use of `markupsafe.Markup` detected
+ securedrop/source_app/utils.py:44:11: S704 Unsafe use of `markupsafe.Markup` detected
+ securedrop/source_app/utils.py:51:22: S704 Unsafe use of `markupsafe.Markup` detected
+ securedrop/source_app/utils.py:65:11: S704 Unsafe use of `markupsafe.Markup` detected
+ securedrop/template_filters.py:24:21: S704 Unsafe use of `markupsafe.Markup` detected

zulip/zulip (+1 -1 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview --select ALL

- zerver/views/documentation.py:292:35: RUF035 Unsafe use of `markupsafe.Markup` detected
+ zerver/views/documentation.py:292:35: S704 Unsafe use of `markupsafe.Markup` detected

Changes by rule (2 rules affected)

code	total	+ violation	- violation	+ fix	- fix
S704	30	30	0	0	0
RUF035	9	0	9	0	0

MichaReiser · 2025-02-05T08:33:04Z

@MichaReiser Can you think of a clever way to default the settings in their new section to the value in their deprecated section?

Clever, no :) But what I'd do is to lift the Flake8Options::into_settings into Configuration::into_settings because that's where you have access to both the Ruff and Flake8 options. Or you change the Flake8Options::into_settings to take a second argument that's an Option<&RuffOptions>

Switches to more verbose labels for references section.

…rize-RUF035-to-S704

MichaReiser · 2025-03-11T12:00:17Z

Thanks @Daverball for rebasing

…15957) ## Summary `RUF035` has been backported into bandit as `S704` in this [PR](PyCQA/bandit#1225) This moves the rule and its corresponding setting to the `flake8-bandit` category ## Test Plan `cargo nextest run` --------- Co-authored-by: Micha Reiser <micha@reiser.io>

[flake8-bandit] Move unsafe-markup-use from RUF035 to S704

f340a85

MichaReiser added this to the v0.10 milestone Feb 5, 2025

MichaReiser added the breaking Backwards-incompatible changes label Feb 5, 2025

This comment was marked as resolved.

Sign in to view

Update json schema

e9a838e

Daverball and others added 4 commits February 5, 2025 10:12

Defaults new settings based on deprecated settings

c7d8370

Merge branch 'main' into recategorize-RUF035-to-S704

f790302

Fixes non-backticked reference in rule docs.

17c084c

Switches to more verbose labels for references section.

Merge branch 'main' into recategorize-RUF035-to-S704

d84eb8c

MichaReiser changed the base branch from main to micha/ruff-0.10 March 10, 2025 14:23

MichaReiser force-pushed the micha/ruff-0.10 branch from 44eec2b to e4e1c58 Compare March 10, 2025 14:28

Daverball added 2 commits March 11, 2025 11:43

Updates deprecated since to correct version

cf0c5ee

Merge remote-tracking branch 'upstream/micha/ruff-0.10' into recatego…

b70925c

…rize-RUF035-to-S704

MichaReiser added 2 commits March 11, 2025 13:05

Update deprecated since

e05ea3b

Nit

5728541

MichaReiser mentioned this pull request Mar 11, 2025

Ruff 0.10 #16600

Merged

2 tasks done

MichaReiser merged commit 2ae5344 into astral-sh:micha/ruff-0.10 Mar 11, 2025

Daverball deleted the recategorize-RUF035-to-S704 branch March 11, 2025 12:24

Navigation Menu

Repository navigation

[`flake8-bandit`] Move `unsafe-markup-use` from `RUF035` to `S704` - #15957

[`flake8-bandit`] Move `unsafe-markup-use` from `RUF035` to `S704`#15957
MichaReiser merged 10 commits into
astral-sh:micha/ruff-0.10from
Daverball:recategorize-RUF035-to-S704

Daverball commented Feb 5, 2025

Uh oh!

This comment was marked as resolved.

MichaReiser commented Feb 5, 2025

Uh oh!

github-actions Bot commented Feb 5, 2025 •

edited

Loading

Uh oh!

MichaReiser commented Feb 5, 2025

Uh oh!

MichaReiser commented Mar 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Daverball commented Feb 5, 2025

Summary

Test Plan

Uh oh!

This comment was marked as resolved.

MichaReiser commented Feb 5, 2025

Uh oh!

github-actions Bot commented Feb 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ruff-ecosystem results

Linter (stable)

Linter (preview)

Uh oh!

MichaReiser commented Feb 5, 2025

Uh oh!

MichaReiser commented Mar 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Feb 5, 2025 •

edited

Loading

`ruff-ecosystem` results