Repository navigation
[pylint] Fix convert a code keyword argument to a positional argument (PLR1722) - #16424
Merged
Merged
Conversation
Contributor
|
ntBre
requested changes
Feb 28, 2025
ntBre
left a comment
Contributor
There was a problem hiding this comment.
Thanks! I think we can simplify the implementation a bit here and also support more use cases at the same time.
Co-authored-by: Brent Westbrook <36778786+ntBre@users.noreply.github.com>
Contributor
Author
|
Hey @ntBre thank you very much for the feedback. Yes, my solution was pretty convoluted. I suspected there it was a better way to do it but I could not find how ;-) Everything works fine. I also added the test cases that you suggested and it seems that the output it is what expected. |
ntBre
reviewed
Mar 2, 2025
ntBre
approved these changes
Mar 3, 2025
ntBre
left a comment
Contributor
There was a problem hiding this comment.
This looks great, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR addresses issue #16396 .
Specifically: