Repository navigation
[pyflakes] Add fix safety section to docs (F601, F602) - #17440
Merged
Merged
Conversation
ntBre
approved these changes
Apr 18, 2025
ntBre
left a comment
Contributor
There was a problem hiding this comment.
Thanks! I also tested this one, and it definitely removes comments.
It could also technically be unsafe if the values have side effects:
foo = {
2: print(2),
2: print(2),
}The rule only offers a fix if the values are equal, but it doesn't consider potential side effects.
I think mentioning the comments is sufficient, though. This example is pretty contrived, and the comment case seems most common.
Contributor
|
Contributor
|
On second thought, I went ahead and added the mention of side effects, just in case. I'll merge once CI finishes! |
pyflakes] Add fix safety section to docs (F601, F602)
ntBre
enabled auto-merge (squash)
April 18, 2025 18:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
add fix safety section to repeated_keys_docs, for #15584