Skip to content

[ty] Update expected diagnostic count in benchmarks - #21269

Merged
MichaReiser merged 1 commit into
mainfrom
micha/update-expected-diagnostics
Nov 4, 2025
Merged

MichaReiser merged 1 commit into
mainfrom
micha/update-expected-diagnostics

Conversation

@MichaReiser

@MichaReiser MichaReiser commented Nov 4, 2025 •

Copy link
Copy Markdown
Member

To unblock CI on main

@MichaReiser MichaReiser added ci Related to internal CI tooling ty The ty type checker labels Nov 4, 2025
@MichaReiser
MichaReiser enabled auto-merge (squash) November 4, 2025 03:13
@MichaReiser
MichaReiser merged commit 4fd8d4b into main Nov 4, 2025
37 of 38 checks passed
@MichaReiser
MichaReiser deleted the micha/update-expected-diagnostics branch November 4, 2025 03:18
@codspeed

codspeed Bot commented Nov 4, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #21269 will degrade performances by 18.19%

Comparing micha/update-expected-diagnostics (4274979) with main (63b1c1e)

Summary

❌ 1 regression
✅ 51 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Mode Benchmark BASE HEAD Change
❌ WallTime medium[colour-science] 11.2 s 13.7 s -18.19%

@github-actions

github-actions Bot commented Nov 4, 2025

Copy link
Copy Markdown
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

carljm added a commit to MatthewMckee4/ruff that referenced this pull request Nov 6, 2025
* main: (188 commits)
  [ty] Discover site-packages from the environment that ty is installed in (astral-sh#21286)
  [ty] Make special cases for `UnionType` slightly narrower (astral-sh#21276)
  Require ignore 0.4.24 in `Cargo.toml` (astral-sh#21292)
  [ty] Favour imported symbols over builtin symbols (astral-sh#21285)
  docs: revise Ruff setup instructions for Zed editor (astral-sh#20935)
  [ty] Update salsa (astral-sh#21281)
  [syntax-error]: no binding for nonlocal  PLE0117 as a semantic syntax error (astral-sh#21032)
  [ty] Constraining a typevar with itself (possibly via union or intersection) (astral-sh#21273)
  [`ruff`] Fix false positives on starred arguments (`RUF057`) (astral-sh#21256)
  [ty] Simplify unions containing multiple type variables during inference (astral-sh#21275)
  [ty] Add `ty_server::Db` trait (astral-sh#21241)
  [ty] Refactor `Range` to/from `TextRange` conversion as prep for notebook support (astral-sh#21230)
  [ty] Fix playground crash when file name includes path separator (astral-sh#21151)
  [`refurb`] Fix false negative for underscores before sign in `Decimal` constructor (`FURB157`) (astral-sh#21190)
  [ty] Allow values of type `None` in type expressions (astral-sh#21263)
  Run codspeed benchmarks with `profiling` profile (astral-sh#21261)
  [ty] Update expected diagnostic count in benchmarks (astral-sh#21269)
  Avoid extra parentheses for long `match` patterns with `as` captures (astral-sh#21176)
  [ty] Update salsa (astral-sh#21265)
  [ty] `dict` is not assignable to `TypedDict` (astral-sh#21238)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Related to internal CI tooling ty The ty type checker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant