Repository navigation
[ty] Improve keyword argument narrowing for nested dictionaries - #24010
Merged
Merged
Conversation
ibraheemdev
requested review from
AlexWaygood,
carljm,
dcreager and
sharkdp
as code owners
March 17, 2026 05:32
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 85.29%. The percentage of expected errors that received a diagnostic held steady at 78.13%. The number of fully passing files held steady at 64/132. |
Memory usage reportMemory usage unchanged ✅ |
|
| Lint rule | Added | Removed | Changed |
|---|---|---|---|
invalid-await |
0 | 40 | 0 |
invalid-return-type |
0 | 1 | 0 |
| Total | 0 | 41 | 0 |
carljm
requested changes
Mar 17, 2026
carljm
left a comment
Contributor
There was a problem hiding this comment.
This change adds false negatives for direct assignments to nested keys:
def f(*, b: int): ...
x: dict[str, dict[str, int]] = {"a": {"b": 1}}
x["a"]["b"] = 1
# This should be an error: x has no top-level key "b".
f(**x)This is correctly an error on main, but a false negative with this PR.
Member
Author
|
@carljm that example seems to error correctly on this PR? |
carljm
approved these changes
Mar 20, 2026
carljm
left a comment
Contributor
There was a problem hiding this comment.
Weird, sorry! I'm sure I tested that... not sure what I did wrong. Maybe I had an earlier branch checked out by accident. Never mind!
carljm
added a commit
that referenced
this pull request
Mar 25, 2026
* main: [`flake8-bandit`] Check tuple arguments for partial paths in `S607` (#24080) [ty] Update Salsa (#24081) Update Rust toolchain to 1.94 and MSRV to 1.92 (#24076) [ty] Move ruffen-docs formatting config to a `ruff.toml` config file (#24074) [ty] `reveal_type` diagnostics in unreachable code (#24070) [ty] Improve keyword argument narrowing for nested dictionaries (#24010) [ty] Preserve blank lines between comments and imports in add-import action (#24066) [ty] Add diagnostic hint for invalid assignments involving invariant generics (#24032) Clarify `extend-ignore` and `extend-select` settings documentation (#24064) [ty] Batch changes to watched paths (#24045) replace deprecated `std::f64::EPSILON` with `f64::EPSILON` (#24067) [ty] Fix untracked reads in Salsa queries that can lead to backdating panics (#24051) [ty] Unions/intersections of gradual types should be assignable to `Never` (#24056) Fix incorrect path for ty_python_semantic in fuzzer (#24052) Bump 0.15.7 (#24049) [ty] ecosystem-analyzer: Fail on newly panicking projects (#24043) Don't show noqa hover for non-Python documents (#24040)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug in #23436 where nested dictionary literals are not tracked, e.g.,
This is unlikely to have an ecosystem impact, but seems worth doing nonetheless.