Repository navigation
[ty] Add missing test case for inline functional TypedDict with an invalid type passed to the name parameter - #24334
Merged
Merged
Conversation
AlexWaygood
requested review from
carljm,
dcreager,
ibraheemdev and
sharkdp
as code owners
March 31, 2026 17:18
This comment was marked as outdated.
This comment was marked as outdated.
AlexWaygood
marked this pull request as draft
March 31, 2026 17:19
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 86.61%. The percentage of expected errors that received a diagnostic held steady at 81.56%. The number of fully passing files held steady at 70/132. |
Memory usage reportMemory usage unchanged ✅ |
… invalid type passed to the `name` parameter
|
AlexWaygood
force-pushed
the
alex/dead-code
branch
from
March 31, 2026 17:23
ff180d1 to
b3074e1
Compare
AlexWaygood
marked this pull request as ready for review
March 31, 2026 17:23
infer/builder/typed_dict.rsname parameter
AlexWaygood
enabled auto-merge (squash)
March 31, 2026 17:25
carljm
added a commit
that referenced
this pull request
Apr 1, 2026
* main: [ty] Add missing test case for inline functional TypedDict with an invalid type passed to the `name` parameter (#24334) [ty] Use `_cls` as argument name for `collections.namedtuple` (#24333) [ty] Emit diagnostic for functional TypedDict with non-literal name (#24331) Add `nested-string-quote-style` formatting option (#24312) `RUF010`: Mark fix as unsafe when it deletes a comment [ty] Fix semantic token classification for properties accessed on instances (#24065) publish installers to `/installers/ruff/latest` on the mirror (#24247)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm pretty sure this branch is unreachable following #24331Currently no tests fail if you delete this branch:
ruff/crates/ty_python_semantic/src/types/infer/builder/typed_dict.rs
Lines 182 to 192 in a42d89b
This PR adds the missing test coverage