Repository navigation
[ty] Validate type qualifiers in functional TypedDict fields and the extra_items keyword to functional TypedDicts - #24360
Merged
Conversation
AlexWaygood
requested review from
dcreager,
ibraheemdev and
sharkdp
as code owners
April 2, 2026 10:43
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 86.76%. The percentage of expected errors that received a diagnostic held steady at 81.53%. The number of fully passing files held steady at 70/132. |
Memory usage reportMemory usage unchanged ✅ |
|
| Lint rule | Added | Removed | Changed |
|---|---|---|---|
invalid-await |
0 | 40 | 0 |
invalid-return-type |
0 | 1 | 0 |
| Total | 0 | 41 | 0 |
Changes in flaky projects detected. Raw diff output excludes flaky projects; see the HTML report for details.
Member
|
Dumb question: at least on |
Member
|
Oh, hah, ok I see that we validate |
Member
Author
It doesn't mean anything; |
Member
|
Alas, I looked for that PR but couldn't find it on the front page, turns out it's on the, uh, second page! Okay thank you. |
charliermarsh
approved these changes
Apr 2, 2026
AlexWaygood
force-pushed
the
alex/refactor-qualifiers
branch
from
April 2, 2026 16:13
e4a6f0e to
17c5acf
Compare
…`extra_items` functional TypedDict keyword argument
AlexWaygood
force-pushed
the
alex/functional-td-qualifiers
branch
from
April 2, 2026 16:20
f3fc283 to
c8adbca
Compare
AlexWaygood
enabled auto-merge (squash)
April 2, 2026 16:21
carljm
added a commit
that referenced
this pull request
Apr 3, 2026
* main: Document adding fixes in CONTRIBUTING.md (#24393) Sort formatter diagnostics in snapshots (#24375) [`pyupgrade`] Fix panic caused by handling of octals in `UP012` (#24390) Upgrade to nix v0.31.2 (#24385) Strip form feeds from indent passed to `dedent_to` (#24381) add recent move of the `deferred` submodule to `.git-blame-ignore-revs` (#24379) [ty] Fix extra_items TypedDict tests (#24367) [ty] Use `infer_type_expression` for validating PEP-613 type aliases (#24370) [`flake8-simplify`] Make the fix for `collapsible-if` (`SIM102`) safe in `preview` (#24371) [ty] Validate TypedDict fields when subclassing (#24338) [ty] pass type context to sequence literals in binary operations (#24197) Add release environment to notify-dependents job (#24372) Bump 0.15.9 (#24369) [ty] Move the `deferred` submodule inside `infer/builder` (#24368) [ty] Infer the `extra_items` keyword argument to class-based TypedDicts as an annotation expression (#24362) [ty] Validate type qualifiers in functional TypedDict fields and the `extra_items` keyword to functional TypedDicts (#24360)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Emit a diagnostic on nonsensical types such as these:
Test Plan
mdtests