Repository navigation
Stabilize Markdown formatting - #27018
Merged
Merged
Conversation
Summary -- This PR stabilizes the Markdown formatting initially added in #22470. It also reverts much of the error plumbing in the LSP that was added in #24150. I considered keeping the `FormatResult::PreviewOnly` variant but went ahead and dropped it since it was unused. Closes #26866. Test Plan -- Updated existing snapshots, dropping `--preview` in some cases
|
ntBre
marked this pull request as ready for review
July 20, 2026 20:11
MichaReiser
approved these changes
Jul 21, 2026
ntBre
added a commit
that referenced
this pull request
Jul 21, 2026
Summary -- This PR stabilizes the Markdown formatting initially added in #22470. It also reverts much of the error plumbing in the LSP that was added in #24150. I considered keeping the `FormatResult::PreviewOnly` variant but went ahead and dropped it since it was unused. Closes #26866. Test Plan -- Updated existing snapshots, dropping `--preview` in some cases
ntBre
added a commit
that referenced
this pull request
Jul 21, 2026
Summary -- This should fix the CI failures I was seeing in #27035: https://github.com/astral-sh/ruff/actions/runs/29854835643/job/88716871906?pr=27035 I guess this didn't appear in #27018 because no formatter files were modified. Test Plan -- CI on this PR, success: https://github.com/astral-sh/ruff/actions/runs/29861350490/job/88738651835?pr=27052
ntBre
added a commit
that referenced
this pull request
Jul 22, 2026
Summary -- This should fix the CI failures I was seeing in #27035: https://github.com/astral-sh/ruff/actions/runs/29854835643/job/88716871906?pr=27035 I guess this didn't appear in #27018 because no formatter files were modified. Test Plan -- CI on this PR, success: https://github.com/astral-sh/ruff/actions/runs/29861350490/job/88738651835?pr=27052
ntBre
added a commit
that referenced
this pull request
Jul 23, 2026
Summary -- This PR stabilizes the Markdown formatting initially added in #22470. It also reverts much of the error plumbing in the LSP that was added in #24150. I considered keeping the `FormatResult::PreviewOnly` variant but went ahead and dropped it since it was unused. Closes #26866. Test Plan -- Updated existing snapshots, dropping `--preview` in some cases
ntBre
added a commit
that referenced
this pull request
Jul 23, 2026
Summary -- This should fix the CI failures I was seeing in #27035: https://github.com/astral-sh/ruff/actions/runs/29854835643/job/88716871906?pr=27035 I guess this didn't appear in #27018 because no formatter files were modified. Test Plan -- CI on this PR, success: https://github.com/astral-sh/ruff/actions/runs/29861350490/job/88738651835?pr=27052
ntBre
added a commit
that referenced
this pull request
Jul 23, 2026
Summary -- This PR stabilizes the Markdown formatting initially added in #22470. It also reverts much of the error plumbing in the LSP that was added in #24150. I considered keeping the `FormatResult::PreviewOnly` variant but went ahead and dropped it since it was unused. Closes #26866. Test Plan -- Updated existing snapshots, dropping `--preview` in some cases
ntBre
added a commit
that referenced
this pull request
Jul 23, 2026
Summary -- This should fix the CI failures I was seeing in #27035: https://github.com/astral-sh/ruff/actions/runs/29854835643/job/88716871906?pr=27035 I guess this didn't appear in #27018 because no formatter files were modified. Test Plan -- CI on this PR, success: https://github.com/astral-sh/ruff/actions/runs/29861350490/job/88738651835?pr=27052
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR stabilizes the Markdown formatting initially added in #22470. It also reverts much of the
error plumbing in the LSP that was added in #24150. I considered keeping the
FormatResult::PreviewOnlyvariant but went ahead and dropped it since it was unused.Closes #26866.
Test Plan
Updated existing snapshots, dropping
--previewin some cases