Repository navigation
Implement import sorting - #633
Merged
Merged
Conversation
charliermarsh
force-pushed
the
charlie/isort
branch
8 times, most recently
from
November 10, 2022 18:52
0d68d43 to
6de2898
Compare
charliermarsh
force-pushed
the
charlie/isort
branch
from
November 10, 2022 23:46
6de2898 to
4c12b78
Compare
charliermarsh
marked this pull request as ready for review
November 10, 2022 23:48
charliermarsh
force-pushed
the
charlie/isort
branch
from
November 10, 2022 23:48
4c12b78 to
ef5e6f5
Compare
charliermarsh
force-pushed
the
charlie/isort
branch
from
November 10, 2022 23:57
ef5e6f5 to
4bd13d3
Compare
|
If somebody is wondering how to add this in pre-commit, use this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements
isort-like import sorting behavior. The intent is to mirrorisortwhen used with the following configuration:The main limitations in the current approach are as follows:
For now, this is implemented via an entirely separator visitor, mostly to make the code easier to reason about. I need to benchmark the impact of that choice.
Resolves: #465.