Skip to content

Less scary ruff format message - #7867

Merged
charliermarsh merged 3 commits into
mainfrom
stablize-ruff-format-a-little
Oct 11, 2023
Merged

charliermarsh merged 3 commits into
mainfrom
stablize-ruff-format-a-little

Conversation

@konstin

@konstin konstin commented Oct 9, 2023

Copy link
Copy Markdown
Member

The ruff formatter has stabilized a good bit since when we added the original message "intended only for experimentation" message. It's time for a less scary message to indicate it is much closer to stable usage than it used to be.

I'm not particular about the specific wording, feel free to change the text to something better.

image

The ruff formatter has stabilized a good bit since when we added the original message "intended only for experimentation" message. It's time for a less scary message to indicate it is much closer to stable usage than it used to be.

I'm not particular about the specific wording, feel free to change the text to something better.

![image](https://github.com/astral-sh/ruff/assets/6826232/225db573-bfda-446f-a403-a577ee270a0b)
@konstin konstin added the formatter Related to the Ruff formatter label Oct 9, 2023

@charliermarsh charliermarsh left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest:

warn_user_once!("`ruff format` is not yet stable, and subject to change in future versions.");

@charliermarsh
charliermarsh enabled auto-merge (squash) October 11, 2023 01:02
@charliermarsh
charliermarsh merged commit ec9d5cd into main Oct 11, 2023
@charliermarsh
charliermarsh deleted the stablize-ruff-format-a-little branch October 11, 2023 11:46
@github-actions

Copy link
Copy Markdown
Contributor

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

formatter Related to the Ruff formatter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants