Repository navigation
Run unicode prefix rule over tokens - #8709
Merged
Merged
Conversation
dhruvmanila
approved these changes
Nov 16, 2023
dhruvmanila
left a comment
Member
There was a problem hiding this comment.
Thanks! I think this fixes #7784 as well and the new node can bring this back to the AST checker.
Contributor
charliermarsh
force-pushed
the
charlie/panci
branch
from
November 16, 2023 02:26
2bb5b78 to
e411173
Compare
charliermarsh
enabled auto-merge (squash)
November 16, 2023 02:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It seems like the range of an
ExprStringLiteralcan be somewhat unreliable when the string is part of an implicit concatenation with an f-string. Using the tokens themselves is more reliable.Closes #8680.
Closes #7784.