Skip to content

[flake8-bandit] Implement S503 SslWithBadDefaults rule - #9391

Merged
charliermarsh merged 8 commits into
astral-sh:mainfrom
qdegraaf:rule/S403
Jan 5, 2024
Merged

charliermarsh merged 8 commits into
astral-sh:mainfrom
qdegraaf:rule/S403

Conversation

@qdegraaf

@qdegraaf qdegraaf commented Jan 4, 2024 •

Copy link
Copy Markdown
Contributor

Summary

Adds S503 rule for the flake8-bandit plugin port.

Checks for function defs argument defaults which have an insecure ssl_version value. See also https://bandit.readthedocs.io/en/latest/_modules/bandit/plugins/insecure_ssl_tls.html#ssl_with_bad_defaults

Some logic and the const can be shared with #9390. When one of the two is merged.

Test Plan

Fixture added

Issue Link

Refers: #1646

@github-actions

github-actions Bot commented Jan 4, 2024 •

Copy link
Copy Markdown
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@charliermarsh charliermarsh added rule Implementing or modifying a lint rule preview Related to preview-mode features labels Jan 4, 2024

@charliermarsh charliermarsh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@charliermarsh
charliermarsh enabled auto-merge (squash) January 5, 2024 01:32
@charliermarsh
charliermarsh merged commit c11f653 into astral-sh:main Jan 5, 2024
@edgarrmondragon edgarrmondragon mentioned this pull request Jan 13, 2024
74 of 75 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview Related to preview-mode features rule Implementing or modifying a lint rule

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants