use fork of tendermint with backported reqwest client #498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joroshiba
approved these changes
Oct 13, 2023
sambukowski
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Overrides tendermint-rs with a version that has the new reqwest-based client backported from 0.34 to 0.33.
Background
Enabling TLS lead to issues with the hyper-tls (and ultimately rustls) based tendermint client failing to parse the host certificate. The hyper and rustls versions used by tendermint-rs pre-0.34 were very old.
Changes
Testing
Tested with composer and the upcoming astria-cli: both are now able to perform http requests against https endpoints and weren't before.
Related Issues
Link any issues that are related, prefer full github links.
Surpasses #494 which was used for debugging
closes #489