Skip to content

conductor: resubscribe with backoff instead of failing #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SuperFluffy merged 3 commits into from
Oct 13, 2023
Merged

conductor: resubscribe with backoff instead of failing #501

SuperFluffy merged 3 commits into from
Oct 13, 2023

Conversation

@SuperFluffy
Copy link
Contributor

@SuperFluffy SuperFluffy commented Oct 13, 2023

Summary

Conductor attempts to subscribe to the sequencer with a constant backoff instead of failing after the first attempt.

Background

Conductor was unnecessarily flaky - instead of trying to resubscribe repeatedly it failed instantly.

Changes

  • Remove the exit condition from the sequencer reader on a failed resubscription to new blocks
  • Try to repeatedly resubscribe to new blocks with a constant backoff of 10 seconds.

Testing

Tested on devnet

@SuperFluffy SuperFluffy requested a review from a team October 13, 2023 21:21
@github-actions github-actions bot added conductor pertaining to the astria-conductor crate sequencer pertaining to the astria-sequencer crate labels Oct 13, 2023
@SuperFluffy SuperFluffy mentioned this pull request Oct 13, 2023
Closed
joroshiba
joroshiba approved these changes Oct 13, 2023
View reviewed changes
@SuperFluffy SuperFluffy merged commit 1463e14 into main Oct 13, 2023
@SuperFluffy SuperFluffy deleted the superfluffy/dont-exit-on-failed-resubscribe branch October 13, 2023 21:54
steezeburger added a commit that referenced this pull request Oct 13, 2023
@steezeburger
Merge branch 'main' into feature/self-serve-rollup-cli
e22cd21 
* main:
  release(conductor): 0.7.0 (#502)
  conductor: resubscribe with backoff instead of failing (#501)
  conductor: spawn driver as task and report exit (#500)
  conductor: never recycle websocket clients (#499)
  use fork of tendermint with backported reqwest client (#498)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joroshiba joroshiba joroshiba approved these changes

@noot noot Awaiting requested review from noot

+1 more reviewer

@sambukowski sambukowski sambukowski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

conductor pertaining to the astria-conductor crate sequencer pertaining to the astria-sequencer crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SuperFluffy @joroshiba @sambukowski